Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle datepicker association reliably #3339

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix: handle datepicker association reliably #3339

merged 4 commits into from
Jan 15, 2025

Conversation

kyubisation
Copy link
Contributor

Closes #3331

@github-actions github-actions bot added target: 2.x pr: peer review required A peer review is required for this pull request labels Jan 13, 2025
@kyubisation kyubisation force-pushed the fix-datepicker-association branch from adc31c9 to c451e40 Compare January 13, 2025 09:50
@github-actions github-actions bot temporarily deployed to pr3339 January 13, 2025 10:12 Inactive
@github-actions github-actions bot temporarily deployed to pr3339-diff January 13, 2025 10:12 Inactive
jeripeierSBB
jeripeierSBB requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. seems to improve stability. Some discussions and topics open for me

src/elements/datepicker/datepicker-next-day/datepicker-next-day.spec.ts Show resolved Hide resolved
src/elements/datepicker/common/datepicker-button.ts Show resolved Hide resolved
src/elements/datepicker/common/datepicker-button.ts Outdated Show resolved Hide resolved
src/elements/datepicker/common/datepicker-button.ts Outdated Show resolved Hide resolved
src/elements/datepicker/common/datepicker-button.ts Show resolved Hide resolved
src/elements/datepicker/datepicker/readme.md Outdated Show resolved Hide resolved
src/elements/datepicker/datepicker-toggle/datepicker-toggle.ts Show resolved Hide resolved
src/elements/datepicker/datepicker/datepicker.ts Show resolved Hide resolved
src/elements/datepicker/datepicker/datepicker.ts Show resolved Hide resolved
src/elements/datepicker/common/datepicker-association-controllers.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr3339 January 14, 2025 15:56 Inactive
@github-actions github-actions bot temporarily deployed to pr3339-diff January 14, 2025 15:56 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jan 15, 2025
@kyubisation kyubisation merged commit 39fc1b3 into main Jan 15, 2025
19 of 20 checks passed
@kyubisation kyubisation deleted the fix-datepicker-association branch January 15, 2025 15:48
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jan 15, 2025
sbb-design-systems-bot bot pushed a commit that referenced this pull request Jan 15, 2025
@kyubisation
fix: handle datepicker association reliably (#3339)
be060fb 
Closes #3331
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
jeripeierSBB pushed a commit that referenced this pull request Jan 16, 2025
@github-actions
chore(2.x): release 2.1.0 (#3328)
6766e22 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](v2.0.3...v2.1.0)
(2025-01-16)


### Features

* improve stacking context for overlay components
([#3349](#3349))
([7ea0640](7ea0640))
* **sbb-container, sbb-sticky-bar:** add 'midnight' and 'charcoal' color
variants
([#3337](#3337))
([6eee274](6eee274))
* **sbb-dialog:** introduce `backdrop` property to control backdrop
density
([#3325](#3325))
([813b141](813b141)),
closes
[#2806](#2806)
* **sbb-menu:** improvements on arrow navigation
([#3341](#3341))
([d90364f](d90364f))


### Bug Fixes

* fix active color of buttons
([#3327](#3327))
([4a13b78](4a13b78))
* handle datepicker association reliably
([#3339](#3339))
([be060fb](be060fb)),
closes
[#3331](#3331)
* **sbb-select:** handle properties change
([#3334](#3334))
([d6b914a](d6b914a))
* **sbb-select:** respect text node mutations for displayed value
([#3329](#3329))
([707366a](707366a)),
closes
[#3298](#3298)


### Documentation

* fix radio button group change event usages
([#3330](#3330))
([c5657de](c5657de))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available target: 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: datepicker arrow disabled after browser navigation
2 participants
@kyubisation @jeripeierSBB