fix for Result File From Resumed MCMC Fails to Save #370 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also extended an existing unit test to cover this situation, since the bug was occurring only after:
|
|
The fix is just to not delete the tmp file? Is that correct? |
|
yup! |
|
I just confirmed that the fix works for Henry's gist example and some of my own code. Thanks Sarah! |
semaphoreP
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @HenryDennen and @wbalmer, thanks for raising an issue about this! I could reproduce your issue, and the patch in this PR fixes it for me. Could you confirm that this works for you too, then I can pull it into main? Thanks!!