fix details output replaceAll not a function

scalecube · Dec 10, 2024 · 13d81ed · 13d81ed
1 parent 829abc8
commit 13d81ed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/app/http-gateway.js b/app/http-gateway.js
@@ -103,7 +103,7 @@ class ApiGateway {
     } else if (userAction === 'deploy_now') {
       return true
     } else if (this.isRobokitTrigger(checkRunName, status, conclusion)) {
-      return deploy.release || deploy.prerelease || this.isKnownBranch(deploy) || this.isFeatureBranch(deploy)
+      return deploy.release || this.isKnownBranch(deploy) || this.isFeatureBranch(deploy)
     } else if (this.isRobokitRelease(checkRunName, status, conclusion)) {
       return true
     } else {

diff --git a/app/utils.js b/app/utils.js
@@ -166,9 +166,11 @@ class Utils {
       if (i < logs.length - 1) {
         status = 'SUCCESS'
       }
-      for (const line of message.split(/\r?\n/)) {
-        const str = line.replace(/(\r\n|\r|\n)/g, ' ')
-        details += `${Utils.getMarker(status)} ${str} \n`
+      if (message !== undefined) {
+        for (const line of message.split(/\r?\n/)) {
+          const str = line.replace(/(\r\n|\r|\n)/g, ' ')
+          details += `${Utils.getMarker(status)} ${str} \n`
+        }
       }
     }
     return details