Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated memberHost/Port; added instead mappedHost/Port #286

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Deprecated memberHost/Port; added instead mappedHost/Port #286

merged 3 commits into from
Jan 2, 2020

Conversation

artem-v
Copy link
Contributor

@artem-v artem-v commented Jan 2, 2020

Fixes #285

@ronenhamias
Copy link
Member

add to examples a simple example to showcase the usage

@artem-v
Copy link
Contributor Author

artem-v commented Jan 2, 2020

add to examples a simple example to showcase the usage

I have created #288. It's too much to do for it in this PR.

@artem-v artem-v merged commit ff60305 into develop Jan 2, 2020
@artem-v artem-v deleted the issues/285/member-host-port branch January 2, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenhamias ronenhamias ronenhamias left review comments

@segabriel segabriel segabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate memberHost/Port settings, create new ones with better names
3 participants
@artem-v @ronenhamias @segabriel