Moves the Meaning to the <note> field. #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates example xliff's - Updates dumper to use new field - Updates loader to use new field - Removes previx of "Meaning:"
Moves the Meaning to the <note> field.
|
Hi @JANorman and thank you for your contribution. I'm really sorry for the delay on this PR. We are a new team of contributors and we are doing a mass review of the old issues/pr. If you still want to push these changes please rebase your PR on the master branch. |
|
@Nyholm OK, I'll rebase when I get time. |
| } | ||
| } | ||
|
|
||
| if ($message instanceof XliffMessage) { |
There was a problem hiding this comment.
Will this ever be true? I do not think so..
|
Sorry, I did not get any notification that you pushed to this PR. I had a comment. |
|
It would be a BC break to change the xml file, right? Have you seen this? #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In compliance with the XLIFF 1.2 format, notes for translators should be placed in the
<note>field of the translation unit. This PR removes the use of theextradataattribute, and instead creates a new<note>element inside the unit.This will bring the library into line with the format and enable external tools to see notes that are applied.