-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class name to region #162
Conversation
2e5b966
to
75ee8ad
Compare
Hey, just one remark: I choose to use the package name (before first And just out of curiosity: do you need to call Best Andreas |
That was always the case. |
We have to reflect on the class names in the whitelist in compat.hpp as well. Otherwise, we get errors. diff --git i/src/scorepy/compat.hpp w/src/scorepy/compat.hpp
index 378af34..9b772ad 100644 src/scorepy/compat.hpp
--- i/src/scorepy/compat.hpp
+++ w/src/scorepy/compat.hpp
@@ -14,11 +14,13 @@ namespace compat
{
/// Region names that are known to have no region enter event and should not report an error
/// on region exit
- static const std::array<std::string, 2> exit_region_whitelist = {
+ static const std::array<std::string, 4> exit_region_whitelist = {
#if PY_MAJOR_VERSION >= 3
- "threading:_bootstrap_inner", "threading:_bootstrap"
+ "threading.Thread:_bootstrap_inner", "threading.Thread:_bootstrap",
+ "threading.TMonitor:_bootstrap_inner", "threading.TMonitor:_bootstrap"
#else
- "threading:__bootstrap_inner", "threading:__bootstrap"
+ "threading.Thread:__bootstrap_inner", "threading.Thread:__bootstrap",
+ "threading.TMonitor:__bootstrap_inner", "threading.TMonitor:__bootstrap"
#endif
};
TMonitor is a class wrapper for the original Thread class by tqdm. Would be good if that is supported as well. |
applied, thanks |
155bd4c
to
f920035
Compare
@NanoNabla can we just drop Python 2 support please: actions/setup-python#672 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bertwesarg
Closes #161
@elwer please give this a try. @Flamefire maybe you have also the chance to look over this?