Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERF-2950] Upgrade grpc to v1.60.1 #93

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[SERF-2950] Upgrade grpc to v1.60.1 #93

merged 1 commit into from
Jan 16, 2024
+34 −105

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Jan 16, 2024 •
edited
Loading

Description

In this PR we upgrade the grpc library to the latest v1.60.1. This upgrade requires a version bump.

Testing considerations

  • Upgrade the go-sdk version in go-chassis and test grpc service in development or staging

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner January 16, 2024 10:14
@Neurostep Neurostep requested a review from fotos January 16, 2024 10:14
@Neurostep Neurostep force-pushed the maksimt/SERF-2950/upgrade-grpc branch from 06faa84 to bdda913 Compare January 16, 2024 10:17
terranisu
terranisu approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@terranisu terranisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📈

laynax
laynax approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@laynax laynax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fotos
fotos approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

@Neurostep Neurostep merged commit bee8366 into main Jan 16, 2024
6 checks passed
@Neurostep Neurostep deleted the maksimt/SERF-2950/upgrade-grpc branch January 16, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laynax laynax laynax approved these changes

@terranisu terranisu terranisu approved these changes

@fotos fotos fotos approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neurostep @fotos @terranisu @laynax