Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated hook contextual_help, use current_screen instead #56

Closed
wants to merge 1 commit into from

Conversation

jhotadhari
Copy link

Hope it won't break anything.

Is there a chance that wp-posts-to-posts will be updated with latest version of wp-scb-framework?

@dikiyforester
Copy link
Contributor

Hi @jhotadhari! Did you check #54?
The issue with #56 that if some class extends _contextual_help() with two arguments it will lead to fatal error.

@andrzejpiotrowski
Copy link

The issue with #56 that if some class extends _contextual_help() with two arguments it will lead to fatal error.
Just logged in to write +- the same 😅

@jhotadhari
Copy link
Author

Hi, oohh yes, true. That will lead to fatal error.

Somehow didn't see #54.
Just thought about an wrapper function. Great #54 _contextual_help_compat does it already. Thanks

@jhotadhari jhotadhari closed this Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants