-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seqFISH: update seqfish reader #227
Conversation
for more information, see https://pre-commit.ci
the failing test is unrelated to this PR and docs build fails due to xarray update i think @LucaMarconato |
@LucaMarconato would be nice if we can merge this soon. The failing tests are however unrelated to this PR. |
Hi @LucaMarconato , if possible, could you help to prioritize merging seqfish reader? It's important for our customers to use spatialdata on our gen2 data. Thanks! |
for more information, see https://pre-commit.ci
@LLehner @adamdingliang I reviewed and made some adjustments to the PR. Thanks @LLehner for the work. Here is a quick script to show a visualization with I will give some more technical comments in our email thread. |
Adds the following:
instance_key
argument inPointsModel
will be deprecated?Interactive
shapes and points are much smaller than and located in the top left corner of images and labels)Example for loading seqfish data set with additional cell boundaries from .geojson file as shapes:
sdata = seqfish(path="path/to/directory/", load_additional_shapes="boundaries")