Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqFISH: update seqfish reader #227

Merged
merged 14 commits into from
Dec 12, 2024
Merged

seqFISH: update seqfish reader #227

merged 14 commits into from
Dec 12, 2024

Conversation

LLehner
Copy link
Member

@LLehner LLehner commented Oct 24, 2024

Adds the following:

  • more flexible regex patterns
  • cell column in transcript list is now optional (@LucaMarconato any news on when the instance_key argument in PointsModel will be deprecated?
  • optionally load additional .geojson files as shapes
  • optionally load additional segmentations or boundaries as shapes
  • Fixes scaling of shapes and points w.r.t. images and labels (when plotting or using Interactive shapes and points are much smaller than and located in the top left corner of images and labels)

Example for loading seqfish data set with additional cell boundaries from .geojson file as shapes:

sdata = seqfish(path="path/to/directory/", load_additional_shapes="boundaries")

@LLehner LLehner requested a review from LucaMarconato October 24, 2024 14:19
@LLehner
Copy link
Member Author

LLehner commented Nov 13, 2024

the failing test is unrelated to this PR and docs build fails due to xarray update i think @LucaMarconato

@LLehner
Copy link
Member Author

LLehner commented Nov 22, 2024

@LucaMarconato would be nice if we can merge this soon. The failing tests are however unrelated to this PR.

@adamdingliang
Copy link

Hi @LucaMarconato , if possible, could you help to prioritize merging seqfish reader? It's important for our customers to use spatialdata on our gen2 data. Thanks!

@LucaMarconato
Copy link
Member

@LLehner @adamdingliang I reviewed and made some adjustments to the PR. Thanks @LLehner for the work. Here is a quick script to show a visualization with spatialdata-plot and one with napari-spatialdata. In the first, I plot the gene expression information onto the cells, represented in turn as labels, shapes and approximated as circles.

I will give some more technical comments in our email thread.
CleanShot 2024-12-12 at 13 24 17
CleanShot 2024-12-12 at 13 18 42

@LucaMarconato LucaMarconato merged commit 96ad663 into main Dec 12, 2024
5 checks passed
@LucaMarconato LucaMarconato deleted the update_seqfish branch December 12, 2024 16:18
@LucaMarconato LucaMarconato changed the title Update seqfish reader seqFISH: update seqfish reader Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants