Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini project 4, finally #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mini project 4, finally #60

wants to merge 2 commits into from

Conversation

Halliax
Copy link

@Halliax Halliax commented Mar 1, 2016

Sorry this is so late!

Review on Reviewable

@LucyWilcox
Copy link

Review status: 0 of 4 files reviewed at latest revision, 5 unresolved discussions.


MarkovHamlet.py, line 47 [r2] (raw file):
why print them? is this just for testing?


MarkovHamlet.py, line 57 [r2] (raw file):
You have some repetitive code in here that you could probably eliminate.


MarkovHamlet.py, line 72 [r2] (raw file):
Giving credit is good! 🐬


MarkovHamlet.py, line 169 [r2] (raw file):
You shouldn't include this if you don't have any doctests.


MiniProject3_Writeup.pdf, line 0 [r2] (raw file):
👍


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants