Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates a11y #6

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Templates a11y #6

merged 8 commits into from
Oct 21, 2024

Conversation

chrisFrazier77
Copy link

No description provided.

@dkonieczek
Copy link

I didn't review the code but I did install nvda and play around with the branch build. Most of these are probably not an issue but heres what I found playing around:

  • when closing autocomplete, term in input disappears
  • any way to select an autocomplete term without clicking on it to then redirect? Looks like it requires you to type the term to then see the rest of autocomplete results for that term. Would probably require keyboard navigation to focus term then hit right arrow?
  • autocomplete terms - use tab to go to to 2nd list option, then down key will read option 3 is focused but outline remains on 2nd option. Pressing tab again then goes to 4th. Same thing happens with facet values
  • Sortby/per page dropdowns - cannot use up/down arrows within list
  • Sortby/per page dropdowns - open dropdown, press down, tab, focus goes to next outside element and dropdown remains open
  • Sortby/per page dropdowns - outline only applies to label text
  • category hierarchy facet - after selection a top level category, should the next subcategory read out the previous selection? May be hard to know how a category filter is intended to be used?
  • when selecting a layoutoption, sort by, or per page value, the page jumps/scrolls down (happening due to spacebar scroll?)
  • Can't tab to product price - how can you get the reader to read prices? Or should they be part of the name reading?
  • slider facet - when using arrows, needs a timeout to allow multiple arrow presses? Or increment by larger value? Or should PageUp/PageDown keys increment by larger values? Holding arrow buttons causes page to freeze (looks to be applying url changes for each increment but only rerenders after unfreezes)
  • slider facet - when handle is focuses, pressing up/down arrows scrolls the page
  • focusing price slider handle reads "price slider slider button slider price slider slider button"
  • on product page bundle - Add All to Cart button after clicked says "unavailable" from button disabled state? But if clicking with mouse it then reads "bundle added"

@korgon korgon linked an issue Oct 21, 2024 that may be closed by this pull request
@korgon korgon merged commit 4613edb into develop Oct 21, 2024
1 check passed
@korgon korgon deleted the templates-a11y branch October 21, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templates Accessibility
3 participants