much safer to look for a specific facet type before clicking #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korgon
requested changes
Jan 26, 2024
Comment on lines
+669
to
+678
| const listFacet = store.facets.filter((facet) => facet.display === 'list')[0]; | ||
| if (!listFacet) this.skip(); | ||
|
|
||
| cy.get(`${config.selectors.sidebar.facetWrapper}`).each((facet) => { | ||
| // find matching facet in dom | ||
| const title = facet.find(config.selectors.sidebar.facetTitle); | ||
| if (listFacet.label.trim() === title.text().trim()) { | ||
| if (listFacet.collapsed) { | ||
| // toggle visibility if collapsed | ||
| listFacet.toggleCollapse(); |
There was a problem hiding this comment.
Since this test is testing the "clear all" functionality - if we wanted to simplify this test we could apply a facet via the store to bypass the DOM entirely.
| if (listFacet.label.trim() === title.text().trim()) { | ||
| if (listFacet.collapsed) { | ||
| // toggle visibility if collapsed | ||
| listFacet.toggleCollapse(); |
There was a problem hiding this comment.
May want to add a 1ms delay after toggleCollapse() usage (apparently needed when testing library components)
cy.wait(1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.