Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.0.13 #41

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

v0.0.13 #41

wants to merge 15 commits into from

Conversation

sebastienrousseau
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 73.42995% with 55 lines in your changes missing coverage. Please review.

Project coverage is 66.08%. Comparing base (d770a16) to head (0344735).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/loader.rs 51.35% 18 Missing ⚠️
src/modules/error.rs 29.41% 12 Missing ⚠️
src/with.rs 66.66% 5 Missing ⚠️
src/libyml/error.rs 71.42% 4 Missing ⚠️
src/libyml/safe_cstr.rs 63.63% 4 Missing ⚠️
src/ser.rs 73.33% 4 Missing ⚠️
src/de.rs 86.36% 3 Missing ⚠️
src/libyml/parser.rs 50.00% 3 Missing ⚠️
src/number.rs 97.01% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   68.28%   66.08%   -2.20%     
==========================================
  Files          22       22              
  Lines        2475     4093    +1618     
==========================================
+ Hits         1690     2705    +1015     
- Misses        785     1388     +603     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Return `ErrorImpl::InvalidProgress` instead of using `unreachable!()` for `Progress::Iterable` and `Progress::Document`, avoiding unexpected panics.
- Add duplicate anchor checks in `Scalar`, `SequenceStart`, and `MappingStart`, returning `ErrorImpl::DuplicateAnchor` and halting parsing for a fail-fast approach.
- Enhance error handling consistency by ensuring parser is set to `None` after fatal errors (like unknown or duplicate anchors).
- Add clearer doc comments with #Overview, #Returns, #Errors, #Examples
- Split out nested_singleton_map & recursive modules for better organization
- Refine error messages and usage examples for optional enums
- Improve maintainability and readability of code in `with.rs`
Comment on lines +206 to +207
// If you want to end parsing entirely, uncomment:
self.parser = None;
Copy link

@AaronDewes AaronDewes Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally uncommented?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AaronDewes at the moment yes. Working on on sebastienrousseau/libyml#7 before going back to #41

@AaronDewes
Copy link

Are you aware of https://simonask.github.io/libyaml-safer/? It may be a better base to use than unsafe-libyaml for your fork. I guess it would be quite a bit of effort, but it's faster and safe rust. Just a suggestion though, the project is great as it is already!

@sebastienrousseau
Copy link
Owner Author

@AaronDewes I'm aware but haven't spent much time looking at it. Nothing wrong with it, I've just been busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants