-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.0.13 #41
base: master
Are you sure you want to change the base?
v0.0.13 #41
Conversation
… documentation for the crate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 68.28% 66.08% -2.20%
==========================================
Files 22 22
Lines 2475 4093 +1618
==========================================
+ Hits 1690 2705 +1015
- Misses 785 1388 +603 ☔ View full report in Codecov by Sentry. |
- Return `ErrorImpl::InvalidProgress` instead of using `unreachable!()` for `Progress::Iterable` and `Progress::Document`, avoiding unexpected panics. - Add duplicate anchor checks in `Scalar`, `SequenceStart`, and `MappingStart`, returning `ErrorImpl::DuplicateAnchor` and halting parsing for a fail-fast approach. - Enhance error handling consistency by ensuring parser is set to `None` after fatal errors (like unknown or duplicate anchors).
- Add clearer doc comments with #Overview, #Returns, #Errors, #Examples - Split out nested_singleton_map & recursive modules for better organization - Refine error messages and usage examples for optional enums - Improve maintainability and readability of code in `with.rs`
…thods for “best effort” conversions
// If you want to end parsing entirely, uncomment: | ||
self.parser = None; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentionally uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronDewes at the moment yes. Working on on sebastienrousseau/libyml#7 before going back to #41
Are you aware of https://simonask.github.io/libyaml-safer/? It may be a better base to use than unsafe-libyaml for your fork. I guess it would be quite a bit of effort, but it's faster and safe rust. Just a suggestion though, the project is great as it is already! |
@AaronDewes I'm aware but haven't spent much time looking at it. Nothing wrong with it, I've just been busy. |
No description provided.