Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cosmwasm #398

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat: update cosmwasm #398

merged 2 commits into from
Oct 25, 2024

Conversation

gluax
Copy link
Contributor

@gluax gluax commented Oct 24, 2024

Motivation

To update cosmwasm dependencies.

Explanation of Changes

Changes the wasmCapabilities function to return the array.
Also, band-aids #395, by just using a temporary directory for the temporary app.

We were also getting deprecation warnings for some actions that they will be dead at the end of the month so I updated all the actions I could.

Testing

Tests pass.

Related PRs and Issues

N/A

@gluax gluax self-assigned this Oct 24, 2024
@gluax gluax force-pushed the feat/upgrade-cosmwasm branch from f8f7957 to 56daad7 Compare October 24, 2024 17:59
@hacheigriega
Copy link
Member

Looks great! How come contracts don't have to be upgraded, though? What's the point of migration instructions like this then? https://github.com/CosmWasm/cosmwasm/blob/v2.0.0/MIGRATING.md

@gluax
Copy link
Contributor Author

gluax commented Oct 24, 2024

Looks great! How come contracts don't have to be upgraded, though? What's the point of migration instructions like this then? https://github.com/CosmWasm/cosmwasm/blob/v2.0.0/MIGRATING.md

I believe it's because you can specify wasmCapabilities to still have support for 1.x versions. Not sure if it's entirely backwards compatible, or if it does some other black magic.

However, the migration guide in the cosmwasm rust SDK made no breaking changes. Just interface changes. Like no longer being able to construct a type directly but using methods to create an instance.

Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a problem that the simulation fails with the VM lockfile error?

panic: Could not lock exclusive.lock. Is a different VM running in the same directory already? [recovered]
	panic: Could not lock exclusive.lock. Is a different VM running in the same directory already?

.github/workflows/build.yml Outdated Show resolved Hide resolved
@gluax
Copy link
Contributor Author

gluax commented Oct 25, 2024

Is it a problem that the simulation fails with the VM lockfile error?

panic: Could not lock exclusive.lock. Is a different VM running in the same directory already? [recovered]
	panic: Could not lock exclusive.lock. Is a different VM running in the same directory already?

Ah, yea, this is fixable. The recommended way from the cosmwasm team is to use a tempdir for every instance of the VM in testing. I'll take a look at that today.

@gluax gluax requested a review from Thomasvdam October 25, 2024 16:50
@gluax gluax force-pushed the feat/upgrade-cosmwasm branch from d850ab9 to d32b54e Compare October 25, 2024 16:52
@gluax gluax force-pushed the feat/upgrade-cosmwasm branch from d32b54e to bb8b147 Compare October 25, 2024 18:24
@gluax gluax force-pushed the feat/upgrade-cosmwasm branch from bb8b147 to e2596c9 Compare October 25, 2024 18:29
@gluax gluax merged commit e2596c9 into main Oct 25, 2024
16 of 17 checks passed
@gluax gluax deleted the feat/upgrade-cosmwasm branch October 25, 2024 18:45
@gluax gluax mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants