-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cosmwasm #398
Conversation
f8f7957
to
56daad7
Compare
Looks great! How come contracts don't have to be upgraded, though? What's the point of migration instructions like this then? https://github.com/CosmWasm/cosmwasm/blob/v2.0.0/MIGRATING.md |
I believe it's because you can specify However, the migration guide in the cosmwasm rust SDK made no breaking changes. Just interface changes. Like no longer being able to construct a type directly but using methods to create an instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a problem that the simulation fails with the VM lockfile error?
panic: Could not lock exclusive.lock. Is a different VM running in the same directory already? [recovered]
panic: Could not lock exclusive.lock. Is a different VM running in the same directory already?
Ah, yea, this is fixable. The recommended way from the cosmwasm team is to use a tempdir for every instance of the VM in testing. I'll take a look at that today. |
d850ab9
to
d32b54e
Compare
d32b54e
to
bb8b147
Compare
bb8b147
to
e2596c9
Compare
Motivation
To update
cosmwasm
dependencies.Explanation of Changes
Changes the
wasmCapabilities
function to return the array.Also, band-aids #395, by just using a temporary directory for the temporary app.
We were also getting deprecation warnings for some actions that they will be dead at the end of the month so I updated all the actions I could.
Testing
Tests pass.
Related PRs and Issues
N/A