Consider middle click config in window mousedown listener #366
Conversation
| @@ -447,7 +447,19 @@ function startUpMainMenu(extensionManager: ExtensionManager, keybindingsManager: | |||
| }); | |||
| } | |||
|
|
|||
| function startUpWindowEvents(mainWebUi: MainWebUi): void { | |||
| function mapEventToMouseButtonActionKey(ev: MouseEvent): string { | |||
There was a problem hiding this comment.
I have noticed this function to be already copy-pasted in Terminal.ts and TerminalAceViewer.ts.
I wish I could extract it's definition to one place and reuse if only you suggested the best place for it
There was a problem hiding this comment.
That is good practice, but this code base has a very limited lifespan.
| @@ -457,7 +469,12 @@ function startUpWindowEvents(mainWebUi: MainWebUi): void { | |||
|
|
|||
| window.document.addEventListener('mousedown', (ev: MouseEvent) => { | |||
| if (ev.which === 2) { | |||
| WebIpc.clipboardReadRequest(); | |||
| const key = mapEventToMouseButtonActionKey(ev); | |||
There was a problem hiding this comment.
We do not need to check for null because it is guaranteed by the if above that exactly middle button is pressed
| const key = mapEventToMouseButtonActionKey(ev); | ||
| const generalConfig = configDatabase.getGeneralConfig(); | ||
| const action = <MouseButtonAction> generalConfig[key]; | ||
| if (action === 'paste') { |
There was a problem hiding this comment.
Shall I also consider paste_selection here ?
There was a problem hiding this comment.
The middle mouse button bug only seems to affect Windows. paste_selection is only available on Linux.
There was a problem hiding this comment.
I was able to reproduce it on Linux (Ubuntu 20.04)
|
Thanks for digging into this. I've been very busy over on the I'll accept this and try out the nightly build. If that is ok then I can do another bug fix release on 0.59. |
Co-authored-by: Dmitriy Baranov <[email protected]>
Fixes #363
The idea is to take into account mouse button click config in the way it is done in Terminal.ts