Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stats/v4 to stats/v5 #148

Closed
wants to merge 8 commits into from
Closed

Conversation

AnnieZhao17
Copy link

@AnnieZhao17 AnnieZhao17 commented Jan 10, 2025

This PR upgrades the stats/v4 library to stats/v5. It also upgrades the Go version due to dependency requirements

The Observability team made a request to upgrade the stats library of Objects Deletion in order to stop using the soon to be deprecated Veneur stats. Ctlstore is within the import chain of Objects Deletion so we need to update the stats library here too

@AnnieZhao17 AnnieZhao17 marked this pull request as ready for review January 10, 2025 22:47
@AnnieZhao17 AnnieZhao17 requested a review from a team as a code owner January 10, 2025 22:47
@zhou-hongyu
Copy link
Contributor

zhou-hongyu commented Jan 13, 2025

Early last year, Ctlstore team migrated from ctlstore repo to ctlstore-internal repo, since then, all of the dev work happened in the later, see ctx:

It looks like objects-deletion-manager is still referring to ctlstore: https://github.com/search?q=repo%3Asegmentio%2Fobjects-deletion-manager%20github.com%2Fsegmentio%2Fctlstore&type=code

I would just point ODM from ctlstore to ctlstore-internal which already has stats/v5 instead of pursuing this PR:

@erikdw
Copy link
Collaborator

erikdw commented Jan 14, 2025

Thanks for pointing that out @zhou-hongyu . Hopefully the migration there is smooth and this PR is not needed. I'll close this for now.

@erikdw erikdw closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants