procstats: bump taskstats and fix file handle leak #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The taskstats file handle is not being closed and thus it is possible for file descriptors to pile up forever. Pull in a much newer version and fix this problem. In addition, I don't think the naked returns or check helper are doing any favors for readability and have removed them in this block in favor of switch error handling. Signed-off-by: Matt Layher <[email protected]>
|
Eek. Thank you. I'm about to go to bed but will review this tomorrow. |
kevinburkesegment
approved these changes
Dec 19, 2024
|
Thanks Kevin! |
|
Thanks for the PR! I did a quick search and it doesn't seem like we're using this internally, which is both fortunate (it's not like FD's have been piling up unnoticed for 5 years) and probably unfortunate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taskstats file handle is not being closed and thus it is possible for file descriptors to pile up forever. Pull in a much newer version and fix this problem.
In addition, I don't think the naked returns or check helper are doing any favors for readability and have removed them in this block in favor of switch error handling.