Fix: Base Fee Off By One #2015
Fix: Base Fee Off By One #2015
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 61.29% 61.49% +0.20%
==========================================
Files 263 264 +1
Lines 24521 24550 +29
==========================================
+ Hits 15030 15097 +67
+ Misses 8369 8324 -45
- Partials 1122 1129 +7
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| d := sdk.Dec{} | ||
| err := d.UnmarshalJSON(bz) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
|
||
| const testCases = [ | ||
| ["No truncation from max priority fee", gp, gp], | ||
| ["With truncation from max priority fee", gp, highgp], | ||
| ["With complete truncation from max priority fee", zero, highgp] | ||
| ]; | ||
|
|
||
| it("Check base fee on the right block", async function () { |
| store := ctx.KVStore(k.storeKey) | ||
| bz, err := baseFeePerGas.MarshalJSON() | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
where does this panic end up getting thrown up to?
There was a problem hiding this comment.
this would get thrown in EndBlock which would halt the chain if thrown, but technically shouldn't get thrown unless something has gone really wrong.
| store := ctx.KVStore(k.storeKey) | ||
| bz, err := baseFeePerGas.MarshalJSON() | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Describe your changes and provide context
This PR fixes the issue where the block base fee was the base fee after the execution of the current block's txs, but it should be the base fee before the block's execution. A separate
PrevBlockBaseFeePerGasPrefixis introduced to store the previous block's base fee per gas to store on the current block.Having base fee on the wrong block impacted tracing. Tracing would fail like this
Testing performed to validate your change
integration test + tested upgrade.