Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account not found error code #2041

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix account not found error code #2041

merged 1 commit into from
Jan 17, 2025

Conversation

dssei
Copy link
Contributor

@dssei dssei commented Jan 15, 2025

Describe your changes and provide context

We return error code 38 not found for case when account found and exists (on account initialization).
Changing this to be 18 invalid request

Testing performed to validate your change

  • unit test
  • integration test

@dssei dssei requested a review from mj850 January 15, 2025 19:23
@dssei dssei merged commit 6bb5ffa into feature/ct_module Jan 17, 2025
28 of 29 checks passed
@dssei dssei deleted the fix_error_code branch January 17, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj850 mj850 mj850 approved these changes

Assignees
No one assigned
Labels
app-hash-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dssei @mj850