Genesis export OOM #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+85
to
+88
| go func() { | ||
| err = types.ValidateGenesisStream(genesisStateCh) | ||
| doneCh <- struct{}{} | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Comment on lines
+89
to
+101
| go func() { | ||
| defer close(genesisStateCh) | ||
| for genesis := range genesisCh { | ||
| var data GenesisState | ||
| err_ := cdc.UnmarshalJSON(genesis, &data) | ||
| if err_ != nil { | ||
| err = err_ | ||
| doneCh <- struct{}{} | ||
| return | ||
| } | ||
| genesisStateCh <- data | ||
| } | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
x/wasm/keeper/genesis.go
Outdated
Comment on lines
142
to
209
| go func() { | ||
| var genState types.GenesisState | ||
| genState.Params = keeper.GetParams(ctx) | ||
| ch <- &genState | ||
|
|
||
| // Needs to be first because there are invariant checks when importing that need sequences info | ||
| for _, k := range [][]byte{types.KeyLastCodeID, types.KeyLastInstanceID} { | ||
| var genState types.GenesisState | ||
| genState.Params = keeper.GetParams(ctx) | ||
| genState.Sequences = append(genState.Sequences, types.Sequence{ | ||
| IDKey: k, | ||
| Value: keeper.PeekAutoIncrementID(ctx, k), | ||
| }) | ||
| ch <- &genState | ||
| } | ||
|
|
||
| keeper.IterateCodeInfos(ctx, func(codeID uint64, info types.CodeInfo) bool { | ||
| var genState types.GenesisState | ||
| genState.Params = keeper.GetParams(ctx) | ||
| bytecode, err := keeper.GetByteCode(ctx, codeID) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| genState.Codes = append(genState.Codes, types.Code{ | ||
| CodeID: codeID, | ||
| CodeInfo: info, | ||
| CodeBytes: bytecode, | ||
| Pinned: keeper.IsPinnedCode(ctx, codeID), | ||
| }) | ||
| ch <- &genState | ||
| return false | ||
| }) | ||
|
|
||
| fmt.Println("About to IterateContractInfo") | ||
| keeper.IterateContractInfo(ctx, func(addr sdk.AccAddress, contract types.ContractInfo) bool { | ||
| // redact contract info | ||
| contract.Created = nil | ||
| var state []types.Model | ||
| keeper.IterateContractState(ctx, addr, func(key, value []byte) bool { | ||
| state = append(state, types.Model{Key: key, Value: value}) | ||
| if len(state) > GENSIS_STATE_STREAM_BUF_THRESHOLD { | ||
| var genState types.GenesisState | ||
| genState.Params = keeper.GetParams(ctx) | ||
| genState.Contracts = append(genState.Contracts, types.Contract{ | ||
| ContractAddress: addr.String(), | ||
| ContractInfo: contract, | ||
| ContractState: state, | ||
| }) | ||
| ch <- &genState | ||
| state = nil | ||
| } | ||
| return false | ||
| }) | ||
| // flush any remaining state | ||
| var genState types.GenesisState | ||
| genState.Params = keeper.GetParams(ctx) | ||
| genState.Contracts = append(genState.Contracts, types.Contract{ | ||
| ContractAddress: addr.String(), | ||
| ContractInfo: contract, | ||
| ContractState: state, | ||
| }) | ||
| ch <- &genState | ||
| return false | ||
| }) | ||
| fmt.Println("Done with IterateContractInfo") | ||
|
|
||
| close(ch) | ||
| }() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
codchen
approved these changes
Jul 24, 2024
yzang2019
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.