Emit CW721 token owner before transfer #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
reviewed
Nov 14, 2024
| @@ -371,6 +372,7 @@ func (k Keeper) execute(ctx sdk.Context, contractAddress sdk.AccAddress, caller | |||
| // prepare querier | |||
| querier := k.newQueryHandler(ctx, contractAddress) | |||
| gas := k.runtimeGasForContract(ctx) | |||
| k.emitCW721OwnerBeforeTransferIfApplicable(ctx, contractAddress, msg) | |||
There was a problem hiding this comment.
confirming this is gasless?
There was a problem hiding this comment.
yeah we use an infinite gas meter for the query https://github.com/sei-protocol/sei-wasmd/pull/67/files#diff-4e16010ab332946722b789b22962fb5a0814d529cd8de443b925d20ccd13705fR1105
stevenlanders
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain use cases require the knowledge of a transferred token's owner. Since it's not possible to get such info after the transfer without looking at historical data, this PR introduces a new event that's emit before the transfer when applicable.