-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch sensu_ctl resouce to use archive_file #112
Conversation
@derekgroh Can you take a look at this and confirm that behavior is the same as before? I don't easily have a Windows setup to do enough testing on. Once we know this works the same I can update the readme docs and changelog. |
af63a62
to
9b6247e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs testing on windows which I can't really provide
@majormoses same for me, marked as Draft for now until we can confirm behavior better on Windows |
9b6247e
to
827fe55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, my branch doesn't have the Chef 15+ pin.
Will get this validated and let you know.
Had some networking issues that I had to work around related to the configuration action, but the install action is working successfully with the change. We may want to introduce some guards to help speed up the run after it is setup as it runs through each resource every time.. Unfortunately, the exe doesn't publish with any version info to use so we'd have to track with another method, maybe a version.info file. |
Good feedback @derekgroh thanks! I'll be working on the cookbook again over this weekend as I have time so any suggestions are appreciated |
827fe55
to
e8ed981
Compare
Rebased on latest master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets only extract when we download a version rather than every chef run.
54013e2
to
5dcefb1
Compare
This is now failing on windows with #116 merged in. Resource needs to be updated to:
There seems to be an odd bug with the |
You might be referring to the behavior I saw a while back that led to my attempt at a fix in #74 I'm not sure of the state of change now since it's a bit old. It should be reviewed though to ensure correct behavior. |
da58b7f
to
25cad64
Compare
This removes the need for a dependency on the seven_zip cookbook since archive_file is a builtin chef resources since Chef 15
Using the `archive_file` resource means less resources are needed and have been removed. Also removing corresponding spec tests here.
We should extract only when we download new files, not everytime. from review: @majormoses
also removed duplicate line
25cad64
to
ddde40c
Compare
@webframp It is a Windows Path issue being immediately available to the My testing showed this could be solved by using The challenge is you have to ensure that the test runs successfully the first time, because any secondary run will succeed, but only because the path value is already set. |
* Switch sensu_ctl resouce to use archive_file This removes the need for a dependency on the seven_zip cookbook since archive_file is a builtin chef resources since Chef 15 * Remove unneeded specs for archive_file Using the `archive_file` resource means less resources are needed and have been removed. Also removing corresponding spec tests here. * Fix indentation on ctl resource * Switch to notify for archive_file action We should extract only when we download new files, not everytime. from review: @majormoses * Update CHANGELOG for sensu_ctl resource changes also removed duplicate line
This removes the need for a dependency on the seven_zip cookbook since
archive_file is a builtin chef resources since Chef 15
fixes #110
Pull Request Checklist
Is this in reference to an existing issue?
Yes.
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Cookstyle (rubocop) passes
Rspec (unit tests) passes
Inspec (integration tests) passes
New Features
Added a Testing Artifact as either an automated test or a manual artifact on the PR.
Added documentation for it to the
README.md
Purpose
Modernize archive handling and remove dependency on seven_zip cookbook
Known Compatibility Issues
Unknown. Windows testing is not complete in CI, will need manual testing.