Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Migrate to clap Derive #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EbonJaeger
Copy link

Simple enough: just migrates the CLI to using the Derive feature of clap.

Signed-off-by: Evan Maddock [email protected]

@EbonJaeger
Copy link
Author

I just discovered that the annotations can be done separately instead of all on one line. Will do that later.

@EbonJaeger EbonJaeger marked this pull request as draft October 14, 2023 21:06
@EbonJaeger EbonJaeger force-pushed the use-clap-derive branch 2 times, most recently from fb23700 to 2cc91c6 Compare December 7, 2023 15:35
@EbonJaeger EbonJaeger marked this pull request as ready for review December 7, 2023 15:36
ermo
ermo previously approved these changes Dec 14, 2023
Copy link
Member

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sound to me.

EDIT: ... but fails on checks. :/

@ermo ermo self-requested a review December 14, 2023 23:55
@ermo ermo dismissed their stale review December 14, 2023 23:56

Checks are failing and branch is behind.

Signed-off-by: Evan Maddock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants