Storyline and selections #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the current storyline menu code.
… the facet list box code.
…ist box to use it. This changes the interface of the facet list box quite a bit.
…ng non-facet entities.
Having code break modularization like that leads to really unexpected results, so I'm removing it. As far as I can tell the call to the map clear button wasn't effecting anything. The call to the tsne clear button was making the tsne view clear its brush and selection styles when its constraint was removed, but also when any constraint from any view was removed.
…on class. The interface changes are for generality so that parts can be shared between set selections and range selections, and to handle bulk additions and removals from set selections.
…lections interface. All views except comparison use the selections interface for their primary selection. Comparison doesn't seem to have anything that can be selected in the UI, but uses it internally. Storyline uses a single selection object for its own node selections and it uses the selections provided by facets for entity selections.
Because that seems to be faster than looping over each item in practice, at least on Chromium.
… styling; changed comments; removed unused code.
…ns on non-facet entity lines. This acts as abstract facets for fields which don't have UI facets. Previously in the storyline view clicking on entity lines for non-facet fields (from manual query mode) did nothing; now it works the same way as for facet entities.
|
What's your demo site? |
|
The demo site has crashed? |
|
Yes, it seems to be down. I don't know why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #168, #183, and #186.
Someone else should play with it (all the views but especially storyline and facet) in case I introduced new bugs, but it's basically ready. It's running on my demo site.