Queries refactoring #216
Closed
Queries refactoring #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a configurable site title and move the about page into a modal
This breaks most or all frontend code that uses the query system.
Because the loading indicator appears more often for longer with the refactoring.
…nerate spurious change events.
This is to sending duplicate queries.
|
Closing this because I need to adjust the last commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for #190 and #189, which also fixes #10. Also a fix for #215.
Note that this touches a lot of code, and see concerns on #189.
I know that guidelines are against having a merge commit in here, but it was a very complicated merge so it seemed better to do it that way.