[16.0] shopinvader_schema_sale: allow to hide some line in the schema (like delivery...) #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paradoxxxzero can you check why the test are failing ? |
paradoxxxzero
force-pushed
the
16.0-add-visible-in-api
branch
from
1ca2b66 to
eeb5766
Compare
|
Is it ok for a |
paradoxxxzero
force-pushed
the
16.0-add-visible-in-api
branch
from
eeb5766 to
74268a5
Compare
|
@sbidoul maybe we should move the logic in sale_cart ? but before let's see my comment here : shopinvader/odoo-shopinvader-carrier#11 (comment) |
If it is functional to the schema IMO it makes sense. |
simahawk
reviewed
Dec 6, 2024
| ) | ||
|
|
||
| def _is_visible_in_shopinvader_api(self): | ||
| self.ensure_one() |
There was a problem hiding this comment.
Using ensure_one on internal methods meant to be used in loops is useless IMO if not counter productive: you'll check N times something that you know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hook to be able to hide "technical" product in the api
See use case here: shopinvader/odoo-shopinvader-carrier#11