Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contribution guide #1620

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

patzick
Copy link
Contributor

@patzick patzick commented Dec 18, 2024

Updates the contribution guidelines to better reflect our current PR workflow and best practices:

  • Clarify that PR title (not individual commits) should follow Conventional Commits format
  • Add guidance on PR maintenance responsibilities
  • Add warning about stale PRs being closed after 2 weeks
  • Add recommendation against rebasing public PRs
  • Emphasize that PRs are squashed on merge

The changes make the workflow clearer for contributors and align with our current practices.

@patzick
Copy link
Contributor Author

patzick commented Dec 18, 2024

related: shopware/shopware#5893

@Isengo1989 Isengo1989 requested a review from Copilot December 18, 2024 10:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @patzick 🎉

Some small textual adjustments ✍️

resources/guidelines/code/contribution.md Outdated Show resolved Hide resolved
@patzick patzick requested a review from Isengo1989 December 18, 2024 10:11
@sushmangupta sushmangupta merged commit e38dd5d into main Dec 18, 2024
8 checks passed
@sushmangupta sushmangupta deleted the docs/update-contribution-guide branch December 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants