Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-36835 - python2 removal #154

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

SG-36835 - python2 removal #154

wants to merge 7 commits into from

Conversation

eduardoChaucaGallegos
Copy link
Contributor

@eduardoChaucaGallegos eduardoChaucaGallegos commented Nov 12, 2024 •
edited
Loading

  • Following the steps from the plan checklist

@eduardoChaucaGallegos eduardoChaucaGallegos requested a review from a team November 13, 2024 23:32
carlos-villavicencio-adsk
carlos-villavicencio-adsk approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job!

I wrote some open questions, mostly nitpicking. I don't want you to address them right now, we can refactor them in the future if they make things complicated right now. They're not part of the scope as the rest of the changes you did.

hooks/scene_operation_tk-houdini.py Outdated
@@ -72,13 +75,13 @@ def execute(
elif operation == "open":
# give houdini forward slashes
file_path = file_path.replace(os.path.sep, "/")
hou.hipFile.load(six.ensure_str(file_path))
hou.hipFile.load(sgutils.ensure_str(file_path))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we can use just str or no extra function given that file_path is already a string (probably).

python/tk_multi_workfiles/file_finder.py Outdated Show resolved Hide resolved
python/tk_multi_workfiles/file_search_cache.py Outdated Show resolved Hide resolved
julien-lang
julien-lang reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good. I just have one pending question.

julien-lang
julien-lang approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-villavicencio-adsk carlos-villavicencio-adsk carlos-villavicencio-adsk approved these changes

@julien-lang julien-lang julien-lang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardoChaucaGallegos @julien-lang @carlos-villavicencio-adsk