Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitly fetch pull request labels #309

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented Oct 26, 2023

Fetch the PR labels explicitly and not for
github.event.pull_request.labels. This means any labels added after the pull request have been created are available to a job re-run.

@frezbo frezbo force-pushed the chore/explicitly-fetch-pr-labels branch from 68105ac to b20f191 Compare October 26, 2023 11:14
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes for this repo github workflows?

@frezbo
Copy link
Member Author

frezbo commented Oct 26, 2023

no changes for this repo github workflows?

yes, this is for customsteps only, I'll get it tested with omni before merging

Fetch the PR labels explicitly and not for
`github.event.pull_request.labels`. This means any labels added after
the pull request have been created are available to a job re-run.

Signed-off-by: Noel Georgi <[email protected]>
@frezbo frezbo force-pushed the chore/explicitly-fetch-pr-labels branch from b20f191 to d577d4d Compare October 27, 2023 10:58
@frezbo
Copy link
Member Author

frezbo commented Oct 27, 2023

/m

@talos-bot talos-bot merged commit d577d4d into siderolabs:main Oct 27, 2023
2 checks passed
@frezbo frezbo deleted the chore/explicitly-fetch-pr-labels branch October 27, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants