feat: support pkgfile frontend. #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
commented
Nov 2, 2023
| @@ -0,0 +1,83 @@ | |||
| // This Source Code Form is subject to the terms of the Mozilla Public | |||
There was a problem hiding this comment.
this was split from dockerfile to dockerignore
frezbo
commented
Nov 2, 2023
| @@ -22,6 +23,10 @@ import ( | |||
|
|
|||
| // DetectGolang checks if project at rootPath is Go-based project. | |||
| func (builder *builder) DetectGolang() (bool, error) { | |||
| if builder.meta.ContainerImageFrontend != config.ContainerImageFrontendDockerfile { | |||
There was a problem hiding this comment.
we can short circuit early, also helps adding conditional checks in so many other places
frezbo
commented
Nov 2, 2023
| if err != nil { | ||
| return false, err | ||
| } | ||
| list, err := listFilesWithSuffix(builder.rootPath, ".md") |
There was a problem hiding this comment.
this was just cleanup, the previous code was wrapped in {}
There was a problem hiding this comment.
it was wrapped for readability, probably unsuccessful attempt to make it more readable 😜
This supports `Pkgfile` projects.
Targets can be set as below in `.kres.yaml`:
```yaml
---
kind: pkgfile.Build
spec:
targets:
- toolchain
reproducibleTargetName: toolchain
additionalTargets:
nonfree:
- nonfree-kmod-nvidia-pkg
```
Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
feat/support-pkgfile-frontend
branch
from
1eacef1 to
32170a7
Compare
smira
reviewed
Nov 2, 2023
smira
approved these changes
Nov 2, 2023
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports
Pkgfileprojects.Targets can be set as below in
.kres.yaml: