Break release into smaller chunks. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return nil, errors.New("no blocked hashes in YAML") | ||
| } | ||
|
|
||
| blockedKeys := make(blockedKeys, len(list.BlockedHashes)+len(list.BlockedHashesHex)) |
Check failure
Code scanning / CodeQL
Size computation for allocation may overflow
| return nil, errors.New("no blocked hashes in YAML") | ||
| } | ||
|
|
||
| blockedKeys := make(blockedKeys, len(list.BlockedHashes)+len(list.BlockedHashesHex)) |
Check failure
Code scanning / CodeQL
Size computation for allocation may overflow
| case "true": | ||
| cfg.tls = &tls.Config{} | ||
| case "skip-verify", "preferred": | ||
| cfg.tls = &tls.Config{InsecureSkipVerify: true} |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check
|
need a rebase lgtm :) thanks for doing that |
|
Thanks! Yeah, I built this on top of this: So, kind of want that going in first, and then I'll rebase this on top of that. |
Signed-off-by: Ville Aikas <[email protected]>
release-ctlog.yaml release-fulcio.yaml release-rekor.yaml release-trillian.yaml release-tuf.yaml Also release setup-scaffolding.sh script. Signed-off-by: Ville Aikas <[email protected]>
Signed-off-by: Ville Aikas <[email protected]>
Signed-off-by: Ville Aikas <[email protected]>
|
Thanks @cpanato PTAL when you get a moment, little easier to review now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #252
Release Note
Documentation
After the release gets created, update getting-started.md with the updated instructions.