Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lilypond package #499

Closed
wants to merge 16 commits into from
Closed

Conversation

alerque
Copy link
Member

@alerque alerque commented Dec 4, 2017

This PR is to track progress on adding a package that will provide support for embedding Lilypond music in SILE documents.

  • Merge Pass through Lua code in script #495 (changes to input grammar needed for this to work)
  • Handle Lilypond file includes
  • Handle inline Lilypond code
  • Pass directory tracking info so Lilypond includes can be relative to the include file
  • Add fragment mode to handle bare notes
  • Pass information about current position in line so inline mode works as well as paragraph mode
  • Make sure vertical space is available and reserved for each system before rendering (this will likely turn out to be a bug in the \img command that needs fixing first).
  • Document usage

Will close #435.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.51% when pulling 55a7b77 on alerque:lilypond into 26ceea6 on simoncozens:master.

@alerque alerque changed the title Add lilypond package [WIP] Add lilypond package Apr 24, 2019
@alerque alerque marked this pull request as draft April 9, 2020 08:55
@alerque alerque changed the title [WIP] Add lilypond package Add lilypond package Apr 9, 2020
@alerque
Copy link
Member Author

alerque commented Apr 19, 2022

I have another current use for this. Who was this maniac who didn't use conventional commits and didn't finish this up for merging?

chore(release): 0.13.0
@ctrlcctrlv
Copy link
Member

Closed, unmerged changes should be made against https://github.com/sile-typesetter/lilypond.sile (see #435).

@ctrlcctrlv ctrlcctrlv closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lilypond support
3 participants