Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #252

Merged
merged 1 commit into from
Oct 24, 2023
Merged

MNT Remove TODO comments #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Context/FixtureContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ public function stepCreateRecordWithTable($type, $id, TableNode $fieldsTable)
{

$class = $this->convertTypeToClass($type);
// TODO Support more than one record
$fields = $this->convertFields($class, $fieldsTable->getRowsHash());
$fields = $this->prepareFixture($class, $id, $fields);

Expand Down Expand Up @@ -522,7 +521,6 @@ public function stepThereAreTheFollowingRecords($dataObject, PyStringNode $strin
$yaml = implode("\n ", $yaml);

// Save fixtures into database
// TODO Run prepareAsset() for each File and Folder record
$yamlFixture = new YamlFixture($yaml);
$yamlFixture->writeInto($this->getFixtureFactory());
}
Expand Down
2 changes: 1 addition & 1 deletion src/Controllers/ModuleSuiteLocator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ protected function loadSuiteConfiguration($suite, Module $module)
// Resolve variables
$resolvedConfig = $this->container->getParameterBag()->resolveValue($suiteConfig);
return [
'type' => null, // @todo figure out what this is for
Copy link
Author

@sabina-talipova sabina-talipova Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will assume that this is due to the initial not entirely correct architecture of the GenericSuiteGenerator class that we are using.
See: https://github.com/Behat/Behat/blob/4.x/src/Behat/Testwork/Suite/Generator/GenericSuiteGenerator.php#L40-L43

'type' => null,
'settings' => $resolvedConfig,
];
}
Expand Down