-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #44 from chillu/pulls/validate-field-fix
Validate field fix
- Loading branch information
Showing
3 changed files
with
194 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,135 @@ | ||
<?php | ||
|
||
class EditableSpamProtectionFieldTest extends SapphireTest | ||
{ | ||
|
||
protected $usesDatabase = true; | ||
|
||
public function setUp() | ||
{ | ||
parent::setUp(); | ||
|
||
Config::inst()->update( | ||
'FormSpamProtectionExtension', 'default_spam_protector', | ||
'EditableSpamProtectionFieldTest_Protector' | ||
); | ||
} | ||
|
||
public function testValidateFieldDoesntAddErrorOnSuccess() | ||
{ | ||
if (!class_exists('EditableSpamProtectionField')) { | ||
$this->markTestSkipped('"userforms" module not installed'); | ||
} | ||
|
||
$formMock = $this->getFormMock(); | ||
$formFieldMock = $this->getEditableFormFieldMock(); | ||
|
||
$formFieldMock | ||
->getFormField() // mock | ||
->expects($this->once()) | ||
->method('validate') | ||
->will($this->returnValue(true)); | ||
|
||
$formMock | ||
->expects($this->never()) | ||
->method('addErrorMessage'); | ||
|
||
$formFieldMock->validateField(array('MyField' => null), $formMock); | ||
} | ||
|
||
public function testValidateFieldAddsErrorFromField() | ||
{ | ||
if (!class_exists('EditableSpamProtectionField')) { | ||
$this->markTestSkipped('"userforms" module not installed'); | ||
} | ||
|
||
$formMock = $this->getFormMock(); | ||
$formFieldMock = $this->getEditableFormFieldMock(); | ||
|
||
$formFieldMock | ||
->getFormField() // mock | ||
->expects($this->once()) | ||
->method('validate') | ||
->will($this->returnValue(false)); | ||
|
||
$formMock->getValidator()->validationError('MyField', 'some field message', 'required'); | ||
|
||
$formMock | ||
->expects($this->once()) | ||
->method('addErrorMessage') | ||
->with($this->anything(), $this->stringContains('some field message'), $this->anything(), $this->anything());; | ||
|
||
$formFieldMock->validateField(array('MyField' => null), $formMock); | ||
} | ||
|
||
public function testValidateFieldAddsDefaultError() | ||
{ | ||
if (!class_exists('EditableSpamProtectionField')) { | ||
$this->markTestSkipped('"userforms" module not installed'); | ||
} | ||
|
||
$formMock = $this->getFormMock(); | ||
$formFieldMock = $this->getEditableFormFieldMock(); | ||
|
||
$formFieldMock | ||
->getFormField() // mock | ||
->expects($this->once()) | ||
->method('validate') | ||
->will($this->returnValue(false)); | ||
|
||
// field doesn't set any validation errors here | ||
|
||
$formMock | ||
->expects($this->once()) | ||
->method('addErrorMessage') | ||
->with($this->anything(), $this->stringContains('default error message'), $this->anything(), $this->anything()); | ||
|
||
$formFieldMock->validateField(array('MyField' => null), $formMock); | ||
} | ||
|
||
protected function getFormMock() | ||
{ | ||
$formMock = $this->getMockBuilder('Form', array('addErrorMessage')) | ||
->disableOriginalConstructor() | ||
->getMock(); | ||
$formMock | ||
->expects($this->any()) | ||
->method('getValidator') | ||
->will($this->returnValue(new RequiredFields())); | ||
|
||
return $formMock; | ||
} | ||
|
||
protected function getEditableFormFieldMock() | ||
{ | ||
$page = new UserDefinedForm(); | ||
$page->write(); | ||
|
||
$formFieldMock = $this->getMockBuilder('TextField') | ||
->disableOriginalConstructor() | ||
->getMock(); | ||
|
||
$editableFormFieldMock = new EditableSpamProtectionField(array( | ||
'ParentID' => $page->ID, | ||
'Name' => 'MyField', | ||
'CustomErrorMessage' => 'default error message' | ||
)); | ||
$editableFormFieldMock->write(); | ||
$editableFormFieldMock->setFormField($formFieldMock); | ||
|
||
return $editableFormFieldMock; | ||
} | ||
|
||
} | ||
|
||
class EditableSpamProtectionFieldTest_Protector implements SpamProtector, TestOnly | ||
{ | ||
public function getFormField($name = null, $title = null, $value = null) | ||
{ | ||
return new TextField($name, 'Foo', $value); | ||
} | ||
|
||
public function setFieldMapping($fieldMapping) | ||
{ | ||
} | ||
} |