Skip to content

Commit

Permalink
Mentioned new invisible Recaptcha option
Browse files Browse the repository at this point in the history
  • Loading branch information
@chillu
chillu authored Jan 12, 2018
1 parent 059191d commit f69ee07
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ your SilverStripe Forms. This does not provide any spam protection out of the
box. For that, you must also download one of the spam protection
implementations. Currently available options are:

* [Recaptcha](https://github.com/chillu/silverstripe-recaptcha)
* [reCAPTCHA v2](https://github.com/chillu/silverstripe-recaptcha)
* [Invisible reCAPTCHA](https://github.com/UndefinedOffset/silverstripe-nocaptcha)
* [MathSpamProtection](https://github.com/silverstripe/silverstripe-mathspamprotection)
* [Akismet](https://github.com/silverstripe/silverstripe-akismet)
* [Mollom](https://github.com/silverstripe-archive/silverstripe-mollom)
Expand Down

7 comments on commit f69ee07

@JorisDebonnet
Copy link
Contributor

@JorisDebonnet JorisDebonnet commented on f69ee07 Mar 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoCaptcha (reCAPTCHA V2) is not the same as Invisible reCAPTCHA though. The linked UndefinedOffset package actually implements NoCaptcha.

(I just tried it out to be sure, putting in an "Invisible reCAPTCHA" site & secret key, but it still renders the NoCaptcha / reCAPTCHA V2 button)

@NightJar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please expand on your explanation @JorisDebonnet ? I looked at the link you provided, but it does not mention 'NoCaptcha' anywhere. I googled and it seems that "NoCaptcha" is the term Google originally used to introduce ReCaptcha v2.

So I'm a bit confused. Of course if they are different services then we should update to reflect that, but it seems like the current offerings of recaptcha are just normal, invisible, and android.

@JorisDebonnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I googled and it seems that "NoCaptcha" is the term Google originally used to introduce ReCaptcha v2.

You're right, NoCaptcha and ReCaptcha v2 are the same. So my point is that chillu's and UndefinedOffset's modules are both offering the same type: chillu calls it reCAPTCHA (2), and UndefinedOffset calls it NoCaptcha, but both are the same. Neither of them support Invisible reCAPTCHA, while this readme edit makes it seem as if the second one does.

@NightJar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. How would you feel about creating a pull request to add support for the Invisible reCaptcha?

@JorisDebonnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm,.. it's not that I actually need the Invisible reCaptcha option, I like ReCaptcha v2 enough. I only made this comment to alert that there is an error in this commit's doc update... :)

@NightJar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. In that case, how would you feel about creating a pull request to alter the description to something like "Alternative reCAPTCHA v2 (a.k.a. NoCaptcha) implementation"?

;P

@JorisDebonnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, that I can do!

I think this would flow better though:

Currently available options are:

Please sign in to comment.