[HeatmapVis] Fix min axis array length off by 1 in error message #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the size of an axis dataset doesn't match the size of the dimension to which it is mapped (via the NX
axesattribute), the error message was so far reporting an incorrect value, off by 1:This was due to
HeatmapViscallinggetPixelEdgeValues, which in turn was callinggetAxisValues(rawValues, pixelCount + 1);to account for the fact that the axis values need to include the value of the outside edge of the last pixel.I didn't try to be smart: I stopped calling
getAxisValuesfromgetPixelEdgeValuesand instead duplicated/tweaked the logic appropriately. SincegetAxisValuesis now only used byLineVis, I moved it and its hook into dedicated files.