Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata viewer layout with overflow #1741

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix metadata viewer layout with overflow #1741

merged 1 commit into from
Jan 24, 2025

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jan 24, 2025 •
edited
Loading

Fix #1740

Before

Screencast.from.2025-01-24.15-31-48.webm

After min-width: 0 in demo, but before flex: 1 in metadata viewer

Screencast.from.2025-01-24.15-33-21.webm

After both fixes

Screencast.from.2025-01-24.15-33-35.webm

@axelboc axelboc requested a review from loichuder January 24, 2025 14:39
loichuder
loichuder approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, a web page made for extra large curved screens 😂

@axelboc axelboc merged commit 34e0a67 into main Jan 24, 2025
8 checks passed
@axelboc axelboc deleted the fix-metadata-viewer branch January 24, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspect fails and collapses GUI when viewing a dataset
2 participants
@axelboc @loichuder