Fix vqshlud_n_s64 implementation to be 64-bit. #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scalar vqshlud_n_s64 function was wrong, and there was no test case for it (or the scalar 32 bit form). Add test cases for the scalar functions (test vectors generated on GCE ARMv9 system), validate the fix for the 64-bit scalar form.
mr-c
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scalar vqshlud_n_s64 function was wrong, and there was no test case for it (or the scalar 32 bit form). Add test cases for the scalar functions (test vectors generated on GCE ARMv9 system), validate the fix for the 64-bit scalar form. Tweak test case generation to generate more "valid" test cases (cases that don't simply saturate to 0 or rapidly saturate to INT_MAX for the function size).