Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental nufft #278

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Incremental nufft #278

merged 8 commits into from
Dec 12, 2024

Conversation

amaurea
Copy link
Collaborator

@amaurea amaurea commented Dec 12, 2024

Mostly adds incremental_nufft, which lets nufft be used effectively in interpolator objects, where you use some resources to build the interpolator, but can then query it efficiently afterwards. Useful when you don't know how many points you will apply it to ahead of time, or if you need low-latency interpolation.

This also adds fourier interpolation as an option to some functions that use interpolation. This involved a breaking change in the interface. The argument modeborder, and mode now controls whether spline or fourier interpolation is done. I don't think many people have used this argument yet, but I'm still worried that it could break things, so please test your codes!

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 31.32530% with 114 lines in your changes missing coverage. Please review.

Project coverage is 39.29%. Comparing base (b5c4c1d) to head (d64e1b7).

Files with missing lines Patch % Lines
pixell/fft.py 7.14% 39 Missing ⚠️
pixell/bench.py 0.00% 33 Missing ⚠️
pixell/utils.py 12.12% 29 Missing ⚠️
pixell/enmap.py 76.92% 12 Missing ⚠️
pixell/reproject.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   39.52%   39.29%   -0.24%     
==========================================
  Files          28       29       +1     
  Lines       10294    10401     +107     
==========================================
+ Hits         4069     4087      +18     
- Misses       6225     6314      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amaurea amaurea merged commit 3c79a01 into master Dec 12, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant