Add card Kyuroro DM-06 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindreslungaard
added
the
dependent on
DanieloV
force-pushed
the
add-card-kyuroro-dm06
branch
from
7ac1733 to
17ce84d
Compare
sindreslungaard
requested changes
Sep 18, 2024
game/cards/dm06/cyber_lord.go
Outdated
|
|
||
| c.Use(fx.Creature, fx.When(fx.BreakShield, func(card *match.Card, ctx *match.Context) { | ||
|
|
||
| event, _ := ctx.Event.(*match.BreakShieldEvent) |
There was a problem hiding this comment.
I think we should check for ok and return here if the event is of another type even though it's already being checked above in fx.breakShield just in case someone makes changes to fx.BreakShield in the future and don't know that it will cause this to panic
DanieloV
force-pushed
the
add-card-kyuroro-dm06
branch
2 times, most recently
from
47c3adf to
4b62251
Compare
DanieloV
force-pushed
the
add-card-kyuroro-dm06
branch
from
4b62251 to
4071548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the last one from dm06 that needed implementing, as the rest are just reprints.