Fix top of evo cards removal #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
DanieloV
force-pushed
the
fix-top-of-evo-cards-removal
branch
from
3c71c21 to
ed8105d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #256
The issue was caused by the movement of the cards from the hiddenzone which is not a true movement in game terms. Was required to make cards like
Pangaea's WillandPouch Shellwork properly. So that when they remove the top card, to no trigger summon effects but still trigger continuous effects of cards.It needed refactoring in many places, but the changes are small. It mostly transitions various implementations to use the
fx.When. Also I think if we get all the cards to usefx.Whenin the future we can better handle effects when multiple cards have an effect triggered at the same time by just modifying the implementation in this method. Maybe even a selectable effect queue at some point.I split it into relevant commits so that it's a bit easier to review.