[python] Fix and test over-indexing semantics (#901)

single-cell-data · Feb 8, 2023 · 662a592 · 662a592
1 parent aeef783
commit 662a592
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/apis/python/src/tiledbsoma/util.py b/apis/python/src/tiledbsoma/util.py
@@ -128,6 +128,10 @@ def slice_to_range(
     if stop is None:
         stop = nonempty_domain[1]
 
+    # Indexing beyond end of array should "trim" to end of array
+    if stop > nonempty_domain[1]:
+        stop = nonempty_domain[1]
+
     if start > stop:
         raise ValueError("slice start must be <= slice stop")
     return (start, stop)

diff --git a/apis/python/tests/test_sparse_nd_array.py b/apis/python/tests/test_sparse_nd_array.py
@@ -622,6 +622,15 @@ def test_csr_csc_2d_read(tmp_path, shape):
             },
             "throws": None,
         },
+        {
+            "shape": (4, 6),
+            "coords": (slice(None), slice(3, 100)),
+            "dims": {
+                "soma_dim_0": [0, 0, 0, 1, 1, 1, 2, 2, 2, 3, 3, 3],
+                "soma_dim_1": [3, 4, 5, 3, 4, 5, 3, 4, 5, 3, 4, 5],
+            },
+            "throws": None,
+        },
         {
             "shape": (4, 6),
             "coords": (slice(1, 2), slice(None)),