Skip to content

Commit

Permalink
[Backport release-1.15][r] Write group-level string metadata as `TILE…
Browse files Browse the repository at this point in the history
…DB_STRING_UTF8`; 1.15.1 (#3481)

* [Backport release-1.15][r] Write group-level string metadata as `TILEDB_STRING_UTF8`

* also 1.15.1
  • Loading branch information
johnkerl authored Dec 19, 2024
1 parent 3e325d6 commit 80e1825
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion apis/r/DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Description: Interface for working with 'TileDB'-based Stack of Matrices,
like those commonly used for single cell data analysis. It is documented at
<https://github.com/single-cell-data>; a formal specification available is at
<https://github.com/single-cell-data/SOMA/blob/main/abstract_specification.md>.
Version: 1.15.0
Version: 1.15.1
Authors@R: c(
person(given = "Aaron", family = "Wolen",
role = c("cre", "aut"), email = "[email protected]",
Expand Down
4 changes: 4 additions & 0 deletions apis/r/NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# tiledbsoma 1.15.1

* Encode string metadata as `TILEDB_STRING_UTF8` instead of `TILEDB_STRING_ASCII` [#3469](https://github.com/single-cell-data/TileDB-SOMA/pull/3469)

# tiledbsoma 1.15.0

## Changes
Expand Down
3 changes: 2 additions & 1 deletion apis/r/src/groups.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,9 @@ void c_group_put_metadata(
std::string s(v[0]);
// We use TILEDB_CHAR interchangeably with TILEDB_STRING_ASCII is
// this best string type?
// Use TILEDB_STRING_UTF8 for compatibility with Python API
xp->grpptr->set_metadata(
key, TILEDB_STRING_ASCII, s.length(), s.c_str());
key, TILEDB_STRING_UTF8, s.length(), s.c_str());
break;
}
case LGLSXP: { // experimental: map R logical (ie TRUE, FALSE, NA) to
Expand Down

0 comments on commit 80e1825

Please sign in to comment.