Make destructors of base classes virtual (#3484) (#3487)

Prevents undefined behavior if we ever attempt to delete a derived class through a pointer to the base class. Co-authored-by: Julia Dark <[email protected]>
single-cell-data · Dec 19, 2024 · 89b0e7f · 89b0e7f
1 parent 38e2705
commit 89b0e7f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/libtiledbsoma/src/geometry/base.h b/libtiledbsoma/src/geometry/base.h
@@ -20,11 +20,13 @@ struct BasePoint {
         , m(m) {
     }
 
+    virtual ~BasePoint() = default;
+
     double_t x;
     double_t y;
     std::optional<double_t> z;
     std::optional<double_t> m;
 };
 }  // namespace tiledbsoma::geometry
 
-#endif  // TILEDBSOMA_GEOMETRY_BASE_H
+#endif  // TILEDBSOMA_GEOMETRY_BASE_H
diff --git a/libtiledbsoma/src/soma/soma_array.h b/libtiledbsoma/src/soma/soma_array.h
@@ -248,7 +248,7 @@ class SOMAArray : public SOMAObject {
     }
 
     SOMAArray() = delete;
-    ~SOMAArray() = default;
+    virtual ~SOMAArray() = default;
 
     /**
      * @brief Get URI of the SOMAArray.

diff --git a/libtiledbsoma/src/soma/soma_collection.h b/libtiledbsoma/src/soma/soma_collection.h
@@ -114,7 +114,7 @@ class SOMACollection : public SOMAGroup {
     SOMACollection() = delete;
     SOMACollection(const SOMACollection&) = default;
     SOMACollection(SOMACollection&&) = default;
-    ~SOMACollection() = default;
+    virtual ~SOMACollection() = default;
 
     using iterator =
         typename std::map<std::string, std::shared_ptr<SOMAObject>>::iterator;

diff --git a/libtiledbsoma/src/soma/soma_group.h b/libtiledbsoma/src/soma/soma_group.h
@@ -114,7 +114,7 @@ class SOMAGroup : public SOMAObject {
     SOMAGroup() = delete;
     SOMAGroup(const SOMAGroup&) = default;
     SOMAGroup(SOMAGroup&&) = default;
-    ~SOMAGroup() = default;
+    virtual ~SOMAGroup() = default;
 
     /**
      * Open the SOMAGroup object.