Skip to content

Commit

Permalink
Pull in somacore rc4. (#1048)
Browse files Browse the repository at this point in the history
Things this gives us:

- "kind" as child collection type parameter
- explicit dataframe sizing in the base spec
- more accurate types
- doc updates (maturity tags)
  • Loading branch information
thetorpedodog authored Mar 3, 2023
1 parent a78b1e6 commit a79c9da
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repos:
- id: mypy
additional_dependencies:
- "pandas-stubs==1.5.3.230214"
- "somacore==1.0.0rc3"
- "somacore==1.0.0rc4"
- "types-setuptools==67.4.0.3"
args: ["--config-file=apis/python/pyproject.toml", "apis/python/src", "apis/python/devtools"]
pass_filenames: false
2 changes: 1 addition & 1 deletion apis/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def run(self):
"pyarrow>=9.0.0",
"scanpy>=1.9.2",
"scipy",
"somacore==1.0.0rc3",
"somacore==1.0.0rc4",
"tiledb==0.20.*",
"typing-extensions", # Note "-" even though `import typing_extensions`
],
Expand Down
4 changes: 2 additions & 2 deletions apis/python/src/tiledbsoma/_dense_nd_array.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class DenseNDArray(NDArray, somacore.DenseNDArray):

def read(
self,
coords: options.DenseNDCoords = (), # type: ignore[type-arg]
coords: options.DenseNDCoords = (),
*,
result_order: options.ResultOrderStr = somacore.ResultOrder.ROW_MAJOR,
partitions: Optional[options.ReadPartitions] = None,
Expand Down Expand Up @@ -120,7 +120,7 @@ def read(

def write(
self,
coords: options.DenseNDCoords, # type: ignore[type-arg]
coords: options.DenseNDCoords,
values: pa.Tensor,
*,
platform_config: Optional[options.PlatformConfig] = None,
Expand Down
2 changes: 1 addition & 1 deletion apis/python/src/tiledbsoma/_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def slice_to_numeric_range(


def dense_indices_to_shape(
coords: options.DenseNDCoords, # type: ignore[type-arg]
coords: options.DenseNDCoords,
array_shape: Tuple[int, ...],
result_order: somacore.ResultOrder,
) -> Tuple[int, ...]:
Expand Down

0 comments on commit a79c9da

Please sign in to comment.