-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Remove no-longer-necessary _query_condition
import
#2286
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
===========================================
+ Coverage 78.75% 90.58% +11.82%
===========================================
Files 140 37 -103
Lines 10756 3875 -6881
Branches 215 0 -215
===========================================
- Hits 8471 3510 -4961
+ Misses 2187 365 -1822
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
clib.SOMAObject.open
on macOS
tiledb
before tiledbsoma
leads to segfault in clib.SOMAObject.open
on MacOS
#2293
0def4ce
to
c3aae56
Compare
c3aae56
to
375a690
Compare
clib.SOMAObject.open
on macOS_query_condition
import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
_query_condition
import_query_condition
import
Updated description re: why the |
Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Ryan Williams <[email protected]>
Issue and/or context: #1960 (comment), #2293
Update:
tiledb
beforetiledbsoma
leads to segfault inclib.SOMAObject.open
on MacOS #2293; occurs on macOS whentiledb
is imported beforetiledbsoma
pytest.fixture
s, verify #1988 #2299 made it harder to trigger while unit-testing, because it madeconftest.py
importtiledbsoma
very early during test initialization (here)_query_condition
import, as this PR does, since it is no longer helping us work around Typeguard issues or the segfault.Previous description
If a
from tiledbsoma import _query_condition
is omitted at the start oftests/__init__.py
, tests segfault duringclib.SOMAObject.open
here:TileDB-SOMA/apis/python/src/tiledbsoma/_tdb_handles.py
Lines 56 to 60 in 0b99e03
Currently this PR is just designed to repro the issue.
Update: GHA repro line, appears to be macOS only.