Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove no-longer-necessary _query_condition import #2286

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented Mar 18, 2024

Issue and/or context: #1960 (comment), #2293

Update:

Previous description

If a from tiledbsoma import _query_condition is omitted at the start of tests/__init__.py, tests segfault during clib.SOMAObject.open here:

# if there is not a valid SOMAObject at the given URI, this
# returns None
soma_object = clib.SOMAObject.open(
uri, open_mode, context.native_context, timestamp=(0, timestamp_ms)
)

Currently this PR is just designed to repro the issue.

Update: GHA repro line, appears to be macOS only.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #2286 (375a690) into main (1c1f362) will increase coverage by 11.82%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2286       +/-   ##
===========================================
+ Coverage   78.75%   90.58%   +11.82%     
===========================================
  Files         140       37      -103     
  Lines       10756     3875     -6881     
  Branches      215        0      -215     
===========================================
- Hits         8471     3510     -4961     
+ Misses       2187      365     -1822     
+ Partials       98        0       -98     
Flag Coverage Δ
libtiledbsoma ?
python 90.58% <ø> (ø)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.58% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams changed the title WIP / DO NOT MERGE: repro segfault in clib.SOMAObject.open WIP / DO NOT MERGE: segfault repro: clib.SOMAObject.open on macOS Mar 18, 2024
@ryan-williams ryan-williams force-pushed the rw/segfault-repro branch 2 times, most recently from 0def4ce to c3aae56 Compare March 25, 2024 17:16
@ryan-williams ryan-williams changed the title WIP / DO NOT MERGE: segfault repro: clib.SOMAObject.open on macOS Remove no-longer-necessary _query_condition import Mar 25, 2024
@ryan-williams ryan-williams marked this pull request as ready for review March 25, 2024 19:42
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@johnkerl johnkerl changed the title Remove no-longer-necessary _query_condition import [python] Remove no-longer-necessary _query_condition import Mar 25, 2024
@ryan-williams
Copy link
Member Author

Updated description re: why the _query_condition import is no longer necessary, merging this now.

@ryan-williams ryan-williams merged commit 7eef2c6 into main Mar 28, 2024
12 checks passed
@ryan-williams ryan-williams deleted the rw/segfault-repro branch March 28, 2024 14:29
johnkerl pushed a commit that referenced this pull request Apr 2, 2024
johnkerl pushed a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants