Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/ci] Unbreak wheel builds #2339

Merged
merged 3 commits into from
Mar 27, 2024
Merged

[python/ci] Unbreak wheel builds #2339

merged 3 commits into from
Mar 27, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 27, 2024

Issue and/or context: Resolves #2337

#2311
[sc-43673]

Changes: per @nguyenv

Notes for Reviewer:

@johnkerl johnkerl changed the title [python/ci] Attempt to unbreak wheel build [python/ci] Attempt to unbreak wheel build [WIP/experiment] Mar 27, 2024
@johnkerl
Copy link
Member Author

johnkerl commented Mar 27, 2024

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #2339 (690252b) into release-1.9 (f680e8e) will increase coverage by 11.90%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.9    #2339       +/-   ##
================================================
+ Coverage        78.68%   90.58%   +11.90%     
================================================
  Files              140       37      -103     
  Lines            10760     3876     -6884     
  Branches           217        0      -217     
================================================
- Hits              8466     3511     -4955     
+ Misses            2195      365     -1830     
+ Partials            99        0       -99     
Flag Coverage Δ
libtiledbsoma ?
python 90.58% <ø> (ø)
r ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.58% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

@johnkerl
Copy link
Member Author

@johnkerl
Copy link
Member Author

Another manual run using the most recent commit:
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8455352258

@johnkerl johnkerl requested a review from nguyenv March 27, 2024 16:53
@johnkerl johnkerl marked this pull request as ready for review March 27, 2024 16:53
@johnkerl johnkerl changed the title [python/ci] Attempt to unbreak wheel build [WIP/experiment] [python/ci] Unbreak wheel builds Mar 27, 2024
@johnkerl
Copy link
Member Author

johnkerl commented Mar 27, 2024

Manual "sdist & wheels" run
https://github.com/single-cell-data/TileDB-SOMA/actions/runs/8455352258
is green

@johnkerl johnkerl merged commit 2cbd508 into release-1.9 Mar 27, 2024
28 checks passed
@johnkerl johnkerl deleted the kerl/wheel-try branch March 27, 2024 17:06
Copy link

The backport to release-1.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.9 release-1.9
# Navigate to the new working tree
cd .worktrees/backport-release-1.9
# Create a new branch
git switch --create backport-2339-to-release-1.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 2cbd50812d02200331579af4d2d39f6efe0f82b8
# Push it to GitHub
git push --set-upstream origin backport-2339-to-release-1.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.9

Then, create a pull request where the base branch is release-1.9 and the compare/head branch is backport-2339-to-release-1.9.

Copy link

This pull request has been linked to Shortcut Story #43673: tiledbsoma 1.9.0.

@johnkerl
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants