[r] Additional nanoarrow refactor followup
#2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #44590: [r] Further post- |
eddelbuettel
changed the title
nanoarrow refactor followup
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
+ Coverage 65.46% 73.55% +8.08%
==========================================
Files 143 52 -91
Lines 12805 4401 -8404
Branches 510 0 -510
==========================================
- Hits 8383 3237 -5146
+ Misses 4334 1164 -3170
+ Partials 88 0 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mojaveazure
approved these changes
Apr 4, 2024
nguyenv
approved these changes
Apr 4, 2024
johnkerl
pushed a commit
that referenced
this pull request
Apr 4, 2024
…) (#2377) Co-authored-by: Dirk Eddelbuettel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
As part of the
nanoarrowrefactoring in #2188, two function declaration and a third inferred one are now redundant as a local helper function can now be removed. This also removes the need forsrc/borrowed.cwhich is now deleted.Changes:
Removal of declarations and helper function file
Notes for Reviewer:
SC 44590