[c++] Address final valgrind issue
#2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes one function no longer needed
|
Thanks! It's all valgrind. And I still fail at my 'pro license' as I once again forgot the value-add provided by |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
===========================================
+ Coverage 66.07% 90.61% +24.53%
===========================================
Files 144 37 -107
Lines 13006 3900 -9106
Branches 511 0 -511
===========================================
- Hits 8594 3534 -5060
+ Misses 4312 366 -3946
+ Partials 100 0 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Apr 8, 2024
johnkerl
pushed a commit
that referenced
this pull request
Apr 8, 2024
* Release (default) allocation of private_data before point to ours * Remove unnecessary buffer set up done by nanoarrow Also removes one function no longer needed * White-space only commit because of clang-format Co-authored-by: Dirk Eddelbuettel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
When running under
valgrind(by for example calling an R script or expression and starting asR -q -d valgrind) and with the propermemcheckinstrumentation for chasing leaks, we were reminded that we lost a small fixed amoumt of 248 bytes per column retrieved. This was due to allocating the (opaque)private_databy default and then (as we do here for buffer management) store the ArrowBuffer / ColumnBuffer container handle.Changes:
By freeing the default allocation before assigning, we no longer leak. We also removed another small assignment (and helper function used) taken care of now by
nanoarrowfollowing #2188.Notes for Reviewer:
SC 44774