-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Addition of ArrowSchema
to TileDB ArraySchema
Converter
#2418
[c++] Addition of ArrowSchema
to TileDB ArraySchema
Converter
#2418
Conversation
ArrowSchema
to TileDB ArraySchema
Converter
Very timely! Just what I may need for tiledb-r too ✨ If you can maybe try to exclude nanoarrow.h from the enforced linting as it only gets us fairly pointless whitespace diffs to an already vendored external file. Working with @dudoslav to see if we can make it a more formal external project to avoid those woes. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2418 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 37 37
Lines 3940 3940
=======================================
Hits 3563 3563
Misses 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good now, and easier for me to use than in an earlier form. I just spotted some small documentation entries. Worth another pass before merging?
8184070
to
2ab5c8e
Compare
@eddelbuettel I have taken a closer scan of all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I think this is ready to move along and have its tires kicked from my side too!
Issue and/or context: #2228
Part of larger branch #2367
Changes:
tiledb_schema_from_arrow_schema
converter that takes in anArrowSchema
withColumnIndexInfo
, which contains info about the dimension's extent and tiles, andPlatformConfig
, which contains info for other TileDBArraySchema
settings such as filters, etc.SOMAObject
create
functions now take inArrowSchema
,ColumnIndexInfo
, andPlatformConfig
arguments; return signature is void to avoid opening the TileDB object until necessarycommon.cc
andcommon.h
Notes for Reviewer: